Repository navigation
Conversation
3 tasks done
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Migration of the remaining core dev server endpoints from
@react-native-community/cli-server-apiinto core (community-cli-plugin).See https://github.com/react/react-native/stack/59664.
This diff
Clean up intended to pair with react/react-native#59316, migrating these endpoints into core. Must land in the same React Native version, and is breaking on the CLI side.
Test Plan
✅ Clean; the one lint warning is in a file this change does not touch.
With this
cli-server-apilinked into RNTester's Metro running react/react-native#59316:curl -X POST /open-stack-framefor a file in the repo answered200with core'sOKbody and launched$REACT_EDITORwith the file.curl -X POST /open-urlwith afile:URL answered400with core's body, and with anhttp://localhostURL answered200and opened the browser.Checklist
react-nativecheckout (instructions).