Repository navigation
Regression from PR #47458: Cannot install React Native from Git anymore #50460
Description
Description
This PR updates shouldSkipGenerationForRncore as such it checks if .../ReactCommon exists before deciding to skip rncore generation, whereas previously it would check .../ReactCommon/react/renderer/components/rncore specifically.
This change breaks installations from Git.
I noticed this while upgrading from 0.76.2 to 0.78.1.
Per my debugging:
- Previous behavior:
- When installing from NPM:
rncoreis pre-generated using theprepackscript - When installing from Git:
rncoregets generated when runningpod install
- When installing from NPM:
- Current behavior:
- When installing from NPM:
rncoreis pre-generated using theprepackscript - When installing from Git:
rncorewill NOT get generated when runningpod installbecause.../ReactCommonis detected as exists even though.../ReactCommon/react/renderer/components/rncoredoes not
- When installing from NPM:
Steps to reproduce
npx @react-native-community/cli@latest init BuggyReactNative
cd ./BuggyReactNative/
npm install 'https://gitpkg.vercel.app/facebook/react-native/packages/react-native?0.78-stable'
cd ./ios/
bundle exec pod install
cd ..
ls ./node_modules/react-native/ReactCommon/react/renderer/components/rncore
# 💥 no such file or directory
# 💥 Xcode won't build the projectReact Native Version
0.78.1
Affected Platforms
Runtime - iOS, Other (please specify)
Output of npx @react-native-community/cli info
Not relevant
Stacktrace or Logs
Not relevant
Reproducer
Run the reproducer bash script so you can test with your toolchain not mine
Screenshots and Videos
No response
Activity
react-native-bot commentedon Apr 3, 2025
Warning
Could not parse version: We could not find or parse the version number of React Native in your issue report. Please use the template, and report your version including major, minor, and patch numbers - e.g. 0.76.2.
react-native-bot commentedon Apr 3, 2025
Warning
Could not parse version: We could not find or parse the version number of React Native in your issue report. Please use the template, and report your version including major, minor, and patch numbers - e.g. 0.76.2.
react-native-bot commentedon Apr 3, 2025
Warning
Missing reproducer: We could not detect a reproducible example in your issue report. Please provide either:
react-native-bot commentedon Apr 28, 2025
This issue is waiting for author's feedback since 24 days. Please provide the requested feedback or this will be closed in 7 days.
MicroDroid commentedon Apr 28, 2025
@react-native-bot the info is all there
react-native-bot commentedon Oct 26, 2025
This issue is stale because it has been open for 180 days with no activity. It will be closed in 7 days unless you comment on it or remove the "Stale" label.
react-native-bot commentedon Oct 26, 2025
This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.
MicroDroid commentedon Oct 26, 2025
.
react-native-bot commentedon Apr 24, 2026
This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.
MicroDroid commentedon Apr 24, 2026
.
react-native-bot commentedon Oct 22, 2026
This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.