Skip to content

Delete legacy catalyst test helpers (#59283) - #59283

Open
christophpurrer wants to merge 22 commits into
react:mainfrom
christophpurrer:export-D126576088
Open

christophpurrer wants to merge 22 commits into
react:mainfrom
christophpurrer:export-D126576088

Conversation

@christophpurrer

@christophpurrer christophpurrer commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary:

Delete the deprecated createCatalystContextForTest and
createMockCatalystInstance helpers from ReactTestHelper, now that every
caller has migrated to createTestReactApplicationContext. Drop the
file-level deprecation suppression and its TODO, which only existed for the
removed helpers.

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D126576088

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 21, 2026
@meta-codesync

meta-codesync Bot commented Oct 21, 2026

Copy link
Copy Markdown

@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126576088.

christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 21, 2026
Summary:
Pull Request resolved: react#59283

Delete the deprecated `createCatalystContextForTest` and
`createMockCatalystInstance` helpers from `ReactTestHelper`, now that every
caller has migrated to `createTestReactApplicationContext`. Drop the
file-level deprecation suppression and its TODO, which only existed for the
removed helpers.

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D126576088
@meta-codesync meta-codesync Bot changed the title Delete legacy catalyst test helpers Delete legacy catalyst test helpers (#59283) Oct 21, 2026
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 21, 2026
Summary:

Delete the deprecated `createCatalystContextForTest` and
`createMockCatalystInstance` helpers from `ReactTestHelper`, now that every
caller has migrated to `createTestReactApplicationContext`. Drop the
file-level deprecation suppression and its TODO, which only existed for the
removed helpers.

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D126576088
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 21, 2026
Summary:
Pull Request resolved: react#59283

Delete the deprecated `createCatalystContextForTest` and
`createMockCatalystInstance` helpers from `ReactTestHelper`, now that every
caller has migrated to `createTestReactApplicationContext`. Drop the
file-level deprecation suppression and its TODO, which only existed for the
removed helpers.

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D126576088
@christophpurrer
christophpurrer force-pushed the export-D126576088 branch 2 times, most recently from f4cec38 to a7a27f8 Compare October 22, 2026 19:29
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 22, 2026
Summary:

Delete the deprecated `createCatalystContextForTest` and
`createMockCatalystInstance` helpers from `ReactTestHelper`, now that every
caller has migrated to `createTestReactApplicationContext`. Drop the
file-level deprecation suppression and its TODO, which only existed for the
removed helpers.

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D126576088
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 22, 2026
Summary:

Delete the deprecated `createCatalystContextForTest` and
`createMockCatalystInstance` helpers from `ReactTestHelper`, now that every
caller has migrated to `createTestReactApplicationContext`. Drop the
file-level deprecation suppression and its TODO, which only existed for the
removed helpers.

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D126576088
@christophpurrer
christophpurrer force-pushed the export-D126576088 branch 2 times, most recently from d7d1f9c to 8a38f15 Compare October 23, 2026 15:59
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 23, 2026
Summary:

Delete the deprecated `createCatalystContextForTest` and
`createMockCatalystInstance` helpers from `ReactTestHelper`, now that every
caller has migrated to `createTestReactApplicationContext`. Drop the
file-level deprecation suppression and its TODO, which only existed for the
removed helpers.

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D126576088
christophpurrer added a commit to christophpurrer/react-native-macos that referenced this pull request Oct 25, 2026
Summary:

Delete the deprecated `createCatalystContextForTest` and
`createMockCatalystInstance` helpers from `ReactTestHelper`, now that every
caller has migrated to `createTestReactApplicationContext`. Drop the
file-level deprecation suppression and its TODO, which only existed for the
removed helpers.

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D126576088
Summary:

Replace the deprecated `BridgeReactContext` + mock `CatalystInstance` setup with `createTestReactApplicationContext` and pass the application directly as the themed base. Add the `ShadowSoLoader` Robolectric shadow the bridgeless helper needs.

Changelog: [Internal]

Differential Revision: D126543755
Summary:

Replace the deprecated `BridgeReactContext` + mock `CatalystInstance` setup with `createTestReactApplicationContext`, stub feature flags before creating the context, and add the `ShadowSoLoader` Robolectric shadow.

Changelog: [Internal]

Differential Revision: D126543660
Summary:

Replace the deprecated `BridgeReactContext` + mock `CatalystInstance` setup with `createTestReactApplicationContext` and add the `ShadowSoLoader` Robolectric shadow the bridgeless helper needs.

Changelog: [Internal]

Differential Revision: D126543381
Summary:

Replace the deprecated `BridgeReactContext` + mock `CatalystInstance` setup with `createTestReactApplicationContext` and add the `ShadowSoLoader` Robolectric shadow the bridgeless helper needs.

Changelog: [Internal]

Differential Revision: D126570688
Summary:

Replace the deprecated `BridgeReactContext` + mock `CatalystInstance` setup with `createTestReactApplicationContext` and add the `ShadowSoLoader` Robolectric shadow the bridgeless helper needs.

Changelog: [Internal]

Differential Revision: D126570689
Summary:

Replace the deprecated `BridgeReactContext` + mock `CatalystInstance` setup with a spied `createTestReactApplicationContext`, stubbing `hasActiveReactInstance` and no-opping `emitDeviceEvent` to preserve emission verification.

Changelog: [Internal]

Differential Revision: D126570690
Summary:

Replace the deprecated `BridgeReactContext` + mock `CatalystInstance` setup with a spied `createTestReactApplicationContext`, moving the `UIManagerModule` stub onto the context spy and no-opping `emitDeviceEvent`.

Changelog: [Internal]

Differential Revision: D126570692
Summary:

Migrate `FabricUIManagerPullModelTest` from the deprecated
`createCatalystContextForTest` helper to `createTestReactApplicationContext`,
so the test builds a bridgeless context directly.

Changelog:
[Internal]

Differential Revision: D126574347
Summary:

Migrate `MountingManagerAnimatedPropsTest` from the deprecated
`createCatalystContextForTest` helper to `createTestReactApplicationContext`,
so the test builds a bridgeless context directly.

Changelog:
[Internal]

Differential Revision: D126574351
…eact#59273)

Summary:

Migrate `SurfaceMountingManagerSynchronousMountPropsTest` from the deprecated
`createCatalystContextForTest` helper to `createTestReactApplicationContext`,
so the test builds a bridgeless context directly.

Changelog:
[Internal]

Differential Revision: D126574353
Summary:

Migrate `SurfaceMountingManagerTest` from the deprecated
`createCatalystContextForTest` helper to `createTestReactApplicationContext`,
so the test builds a bridgeless context directly. Add the `ShadowSoLoader`
Robolectric shadow, which the new helper needs to mock the component factory.

Changelog:
[Internal]

Differential Revision: D126574354
Summary:

Migrate `BaseViewManagerDelegateTest` from the deprecated
`createCatalystContextForTest` helper to `createTestReactApplicationContext`,
so the test builds a bridgeless context directly. Add the `ShadowSoLoader`
Robolectric shadow, which the new helper needs to mock the component factory.

Changelog:
[Internal]

Differential Revision: D126574355
Summary:

Migrate `ImageLoaderModuleTest` from the deprecated
`createCatalystContextForTest` helper to `createTestReactApplicationContext`,
so the test builds a bridgeless context directly. Stub the feature flags
before context creation, since the bridgeless context reads them during init.

Changelog:
[Internal]

Differential Revision: D126574356
Summary:

Migrate `ShareModuleTest` from the deprecated `createCatalystContextForTest`
helper to `createTestReactApplicationContext`, so the test builds a bridgeless
context directly. Add the `ShadowSoLoader` Robolectric shadow and stub the
feature flags before context creation, since the bridgeless context reads
them during init.

Changelog:
[Internal]

Differential Revision: D126574357
Summary:

Migrate `ReactScrollViewHelperFlingAnimatorTest` from the deprecated
`createCatalystContextForTest` helper to `createTestReactApplicationContext`,
so the test builds a bridgeless context directly. Stub the feature flags
before context creation, since the bridgeless context reads them during init.

Changelog:
[Internal]

Differential Revision: D126574358
Summary:
Migrate `SurfaceMountingManagerEventOrderingTest` from the deprecated
`createCatalystContextForTest` helper to `createTestReactApplicationContext`,
so the test builds a bridgeless context directly.

Changelog:
[Internal]

Differential Revision: D126574360
Summary:

Migrate `ThemedReactContextTest` from the deprecated
`createCatalystContextForTest` helper to `createTestReactApplicationContext`,
so the test builds a bridgeless context directly. Stub the feature flags
before context creation, since the bridgeless context reads them during init.

Changelog:
[Internal]

Differential Revision: D126574361
Summary:

Migrate `BlobModuleTest` from the deprecated `createCatalystContextForTest`
helper to `createTestReactApplicationContext`, so the test builds a bridgeless
context directly. Add the `ShadowSoLoader` Robolectric shadow and stub the
feature flags before context creation, since the bridgeless context reads
them during init.

Changelog:
[Internal]

Differential Revision: D126574362
Summary:

Migrate `TouchEventDispatchTest` from the deprecated
`createCatalystContextForTest` helper to `createTestReactApplicationContext`,
so the test builds a bridgeless context directly. Install a mocked
`ReactQueueConfiguration` via `initializeMessageQueueThreads` to satisfy the
UI-thread check in `FabricEventDispatcher`, which the mock catalyst
previously provided.

Changelog:
[Internal]

Differential Revision: D126574364
Summary:
Migrate `ReactScrollViewTouchCancelTest` from the deprecated
`BridgeReactContext` + mock `CatalystInstance` setup to
`createTestReactApplicationContext`, so the test builds a bridgeless context
directly. Add the `ShadowSoLoader` Robolectric shadow the bridgeless helper
needs.

Changelog:
[Internal]

Differential Revision: D127469706
Summary:
Migrate `ReactEditTextOutlineTest` from the deprecated
`createCatalystContextForTest` helper to `createTestReactApplicationContext`,
so the test builds a bridgeless context directly. Add the `ShadowSoLoader`
Robolectric shadow the bridgeless helper needs.

Changelog:
[Internal]

Differential Revision: D127469707
Summary:

Delete the deprecated `createCatalystContextForTest` and
`createMockCatalystInstance` helpers from `ReactTestHelper`, now that every
caller has migrated to `createTestReactApplicationContext`. Drop the
file-level deprecation suppression and its TODO, which only existed for the
removed helpers.

Changelog:
[Internal]

Reviewed By: javache

Differential Revision: D126576088
@github-actions

Copy link
Copy Markdown

Visual regression

No visual differences at ef8bb2b04649.

ios: no capture

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant