Skip to content

Fix uncontrolled multiline TextInput not expanding on iOS #59417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jasozh wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix uncontrolled multiline TextInput not expanding on iOS #59417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a24cbca
Add auto-expanding multiline TextInput example to RNTester (#59416)
jasozh Oct 23, 2026
bc23e21
Fix uncontrolled multiline TextInput not expanding on iOS
jasozh Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...es/react-native/ReactCommon/react/renderer/components/textinput/BaseTextInputShadowNode.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,9 @@ class BaseTextInputShadowNode
const auto &stateData = BaseShadowNode::getStateData();
const auto &reactTreeAttributedString = getAttributedString(layoutContext);

if (stateData.reactTreeAttributedString.isContentEqual(reactTreeAttributedString)) {
if (stateData.reactTreeAttributedString.isContentEqual(reactTreeAttributedString) &&
stateData.reactTreeAttributedString.getBaseTextAttributes() ==
reactTreeAttributedString.getBaseTextAttributes()) {
return;
}

Expand Down
17 changes: 0 additions & 17 deletions packages/rn-tester/js/examples/TextInput/TextInputExample.ios.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,23 +778,6 @@ const textInputExamples: Array<RNTesterModuleExample> = [
);
},
},
{
title: 'Auto-expanding',
render: function (): React.Node {
return (
<View>
<ExampleTextInput
placeholder="height increases with content"
defaultValue="React Native enables you to build world-class application experiences on native platforms using a consistent developer experience based on JavaScript and React. The focus of React Native is on developer efficiency across all the platforms you care about - learn once, write anywhere. Facebook uses React Native in multiple production apps and will continue investing in React Native."
multiline={true}
enablesReturnKeyAutomatically={true}
returnKeyType="go"
style={[styles.multiline, styles.multilineExpandable]}
/>
</View>
);
},
},
{
title: 'TextInput maxLength',
render: function (): React.Node {
Expand Down
14 changes: 14 additions & 0 deletions packages/rn-tester/js/examples/TextInput/TextInputSharedExamples.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1192,6 +1192,20 @@ module.exports = [
);
},
},
{
title: 'Auto-expanding (uncontrolled)',
render: function (): React.Node {
return (
<View>
<ExampleTextInput
placeholder="height should grow up to 10 lines"
multiline={true}
numberOfLines={10}
/>
</View>
);
},
},
{
title: 'Drag and drop',
render: function (): React.Node {
Expand Down
Loading