Skip to content

Fix VirtualView clipping with stale parent offset on Android #59421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christophpurrer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix VirtualView clipping with stale parent offset on Android #59421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...tive/ReactAndroid/src/main/java/com/facebook/react/views/virtual/view/ReactVirtualView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ public class ReactVirtualView(context: Context) :
@VisibleForTesting
internal fun doAttachedToWindow() {
scrollView = getScrollView()
// Ancestors that are already laid out won't fire onLayoutChange again, so the offset must be
// computed here even if this view hasn't had its own layout yet.
updateParentOffset()
// onAttachedToWindow is usually called before layout but there are cases where it's called
// after. If called after, we need to report the updated layout to the VirtualViewContainer
Expand Down
Loading