Repository navigation
Render page: not ready until the analysis is coloured - #769
Closed
adamjohnwright wants to merge 2 commits into
Closed
adamjohnwright wants to merge 2 commits into
adamjohnwright wants to merge 2 commits into
Conversation
With a token, the render page reported ready as soon as a view was drawn, before its analysis colouring arrived, and before a result holding one resource besides TOTAL was loaded again for that resource. The render service then cached the figure uncoloured, or coloured for TOTAL, under the token. A token whose result could not be read was dropped and the figure drawn with no colouring at all. - AnalysisService.settled: the result on show is the one the address settles on (the default resource's load included). - The diagram and the illustration say which analysis they last coloured; the overview says whether its tree is the one fetched for the current token and resource. The page waits on these, publishes the analysis in __renderState.analysis, and fails when the analysis cannot be read. - Render cache key v12, so figures cached without their colouring are not served. - e2e: each view held back for its default resource, and an unreadable token; each fails on the previous page code. pdf-export spec 002 needs this first (its plan's step 0). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The new tests were recorded against the Release 98 graph, so their content service answers were new bodies of routes whose known type problems are counted (tools/api-types/known-problems.json), and two counts went up. Every answer they read is already recorded from Release 97, so they replay those, and the Release 98 bodies and release files are dropped. Moving the whole suite to Release 98 is its own change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Replaced by the next PR (render-overlay-wait-3), after this one's review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #768. CI there failed the check of recorded content API answers: the new tests had been recorded against the Release 98 graph, while the suite's recordings are from Release 97. They now replay the Release 97 answers already recorded for the same requests. Moving the whole suite to Release 98 is its own change.
With an analysis token, the render page reported ready as soon as a view was drawn. That was before its analysis colouring arrived, and, for a result holding one resource besides TOTAL, before the second load that colours it for that resource, as the pathway browser shows it. The render service then cached the figure under the token, uncoloured or coloured for TOTAL. A token whose result could not be read was dropped, and the figure was drawn with no colouring at all and reported ready.
What changes
AnalysisService.settled: the result on show is the one the address settles on, including the default resource's second load.__renderState.analysis(token and resource);v12, so figures cached without their colouring are not served. The README's readiness notes say why.Tests
Four new e2e tests on the render page, with a made-up token answered in the test:
All four fail on the previous page code: it was ready before the held-back colouring arrived, and the 410 case gave a figure rather than an error. All four pass with this change.
Belongs to pdf-export's spec 002 (the analysis report), whose plan makes this its step 0. It also fixes figures rendered with a token today.
🤖 Generated with Claude Code