Repository navigation
Interactor page: show the partners without waiting for UniProt - #773
Closed
adamjohnwright wants to merge 1 commit into
Closed
adamjohnwright wants to merge 1 commit into
adamjohnwright wants to merge 1 commit into
Conversation
The page waited for UniProt's record, a third party asked only for synonyms, in the same forkJoin as the interactions. When UniProt was slow the page stayed on its spinner with the interactions already in hand, which failed "shows the partners of an interactor" in CI on every retry. UniProt is now asked apart and fills the synonyms (and the species, when the search names none) whenever it answers. The test holds UniProt unanswered, so it no longer depends on a third party; it fails against the old component. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Replaced by the rebased branch fix/interactor-uniprot-wait-2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No spec: a single-PR fix.
The interactor page asked UniProt (a third party, used only for synonyms) in the same
forkJoinas the interactions, so a slow UniProt left the page on its spinner with the interactions already loaded. That failedinteractor-errors.spec.ts"shows the partners of an interactor" on every retry in #772's CI, where UniProt's request never answered.🤖 Generated with Claude Code