Repository navigation
e2e: recordings from Release 98; replay keys a query's parameters in order - #775
Merged
Merged
Conversation
…order The whole suite re-recorded against the Release 98 backend, and Release 97's saved release files and two orphan recordings (tests renamed long ago, the only ones still saying 97) removed. What the move needed: - A new analysis result for the seven tests that read one: the Release 97 result was removed with the release. Made on the local analysis service from eight checkpoint genes; it finds 8 entities in R-HSA-69620. - Circadian clock's illustration lost its <foreignObject> in Release 98, so the test that an unexportable figure says so puts one back. - The dragged-tissue test holds its submission unanswered: it is about the stepper, and an answered submission moves the form past the step. - The legacy-link tests back out of the pathway browser mid-load; the reads they abandon are listed in check-har's ABANDONED, as two already were. - Stubbed answers say release 98. Replay keys a request's query with its parameters in order. The site asks for one pathway's details with the same parameters in two orders from two services, and which a test makes depends on timing: a recording held one, replay was asked for the other and aborted it. The probes' .api.json files are keyed again on load, so their older keys still match. check-har uses the same key. Checks moved, with reasons: - known-problems.json: six totals up. Compared by kind with main, every kind but one is one main already counted; there are more recorded answers on those routes (3-4 more on three, 1 on the reaction exporter) and Release 98's objects are larger. The one new kind: a releaseStatus field in a pathways/low/entity answer, which the site's type does not list. - schema.spec: no recorded search answer has a deleted object's entry any more (Release 97 offered two for TP53; Release 98 offers none for what the tests ask), so that kind is no longer one the recordings cover. Also: the reaction view's render state carries no analysis (tested; set aside from #772 for this move), and the failure message drops a host written in capitals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
adamjohnwright
added a commit
that referenced
this pull request
Nov 2, 2026
From #775's review: the popup's type lists releaseStatus; ABANDONED pinned; comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No spec: test fixtures and the replay harness. Moves the e2e recordings from Release 97 to Release 98, as the beta backend now serves.
What changed
.api.jsonkeys are normalised on load, andcheck-haruses the same key. A unit test covers it, seen failing without the sort.Tests the move needed
<foreignObject>in Release 98, so the "a figure that cannot be made says so" test puts one back.check-har'sABANDONEDlist.Checks moved, with reasons
known-problems.json: six totals up. Compared kind by kind with main, all but one are kinds main already counts. The routes have more recorded answers (3–4 more on three, 1 more on the reaction exporter), and Release 98's objects are larger. The one new kind is areleaseStatusfield in apathways/low/entityanswer, which the site's type does not list (1 instance).schema.spec: no recorded search answer holds a deleted object's entry any more (Release 97 offered two for TP53; Release 98 offers none for anything the tests ask), so that entry kind is no longer covered by recorded data.Also
Local results: 424 passed, 0 failed, 7 skipped. One of those skips was caused by the key change; it is fixed and the test passes. Release 97's last skipped count was 6.
🤖 Generated with Claude Code