Skip to content

Render service, from #778's review: RENDER_FILES checked only when started - #779

Merged
adamjohnwright merged 1 commit into
mainfrom
render/local-files-3
Nov 2, 2026
Merged

adamjohnwright merged 1 commit into
mainfrom
render/local-files-3

Conversation

@adamjohnwright

Copy link
Copy Markdown
Contributor

Follow-up to #778, from its review (low):

  • RENDER_FILES check: it ran whenever service.ts was imported, so a test run with a bad RENDER_FILES in the shell would stop its vitest worker. It now runs only when the service is started.
    • Checked by hand: the service started with a missing folder exits 2.
    • The service and module-load tests pass with the same bad value exported.
  • RENDER_CACHE_MAX docs: "0 disables" read as turning the cache off, and it doesn't: 0 removes the size limit.
    • The README's table and the service's header now say the cache cannot be turned off, and that a fresh RENDER_CACHE_KEY gives a cold run.
    • Found when a "cold" measurement (pdf-export T007) still got cache hits.

🤖 Generated with Claude Code

…arted

The RENDER_FILES check ran whenever service.ts was imported, so a test run
with a bad RENDER_FILES in the shell stopped its worker. It now runs only when
the service is started. RENDER_CACHE_MAX's "0 disables" read as turning the
cache off; 0 removes the size limit, and the README and header now say the
cache cannot be turned off and a fresh RENDER_CACHE_KEY gives a cold run.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@adamjohnwright
adamjohnwright merged commit 7d38a73 into main Nov 2, 2026
8 checks passed
@adamjohnwright
adamjohnwright deleted the render/local-files-3 branch November 2, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant