Skip to content

Spec 001 T008, from #106's review: the lettering reader's edge cases - #107

Merged
adamjohnwright merged 1 commit into
mainfrom
t008/review
Nov 3, 2026
Merged

adamjohnwright merged 1 commit into
mainfrom
t008/review

Conversation

@adamjohnwright

Copy link
Copy Markdown
Contributor

Spec 001, T008 (research R4), the low findings of #106's review. Each was reproduced as a failing test first, and each fix has a mutant that the tests catch.

  • Letter holes. The counters of B, O, d… are left out before the baseline vote. Before, a short label's holes could set the baseline ("BBB" read 62% small). Release 98's smallest labels are long names and were unaffected: R4's numbers, recounted with this reader, stand.
  • Exponents (1e-3, 1E-3) are read as numbers, not as commands.
  • A subpath begun after a close without a move starts where the last one began, instead of joining it.
  • Each command's count of numbers is checked (C takes six, not any even count).
  • A transformed label, or one inside a transformed group other than the render service's viewport, is unread, so the figure is reported as unmeasured. The groups are followed through the markup in one pass of its tags.
  • An ancestor's illustration standing in for an event links with the event selected.
  • Stale wording of the 5 pt floor is gone from the code's comments, from R4, and from T018's note.

All 150 tests pass against the fixture graph.

🤖 Generated with Claude Code

A letter's holes are left out before the baseline vote; an exponent, in either case, is
a number; a subpath begun after a close starts where the last one began; each command's
count of numbers is checked; a label transformed, or in a transformed group other than
the viewport, is unread. An ancestor's illustration standing in links with the event
selected. Stale wording of the 5 pt floor is gone. R4's numbers, recounted, stand.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@adamjohnwright
adamjohnwright merged commit dba9983 into main Nov 3, 2026
2 checks passed
adamjohnwright added a commit that referenced this pull request Nov 3, 2026
Spec 001 T008, from #107's and #108's reviews: the lettering reader's lines, ties and markup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant