Skip to content

Spec 001 T009: the analysis service's answers, measured (replaces #117) - #118

Closed
adamjohnwright wants to merge 7 commits into
mainfrom
t009/review-6
Closed

adamjohnwright wants to merge 7 commits into
mainfrom
t009/review-6

Conversation

@adamjohnwright

Copy link
Copy Markdown
Contributor

Spec 001, task T009 (research R6). This replaces #117 (and before it #112–#116), each closed after its review. Each commit after the first holds one review's fixes.

From #117's review:

  • Medium: T010's stub now answers a summary whose pathway count depends on includeDisease, so T020's test catches a client that leaves the parameter out.
  • Lows:
    • the stub also gives a found/entities 404, and a 410 from later calls;
    • a 410, or a 404 from the CSV call, after the first call succeeded is mapped to gone-token or unknown-token;
    • a request with no Accept header is answered, as the service answers it (re-run);
    • the possible difference in the identifiers-found count is now listed among FR-012's expected differences.
  • Not taken: the claim that nothing clears the CSV's temporary files. The service's own FileDeletorScheduler clears that folder every 15 minutes, so R6's "about half an hour" stands.

It changes documents only.

🤖 Generated with Claude Code

adamjohnwright and others added 7 commits November 3, 2026 12:35
Against a non-production instance on release 98, with tokens the
service reads by its own rules and one small analysis; nothing in its
storage was touched.

- The service reads a stored result first and judges a token's date
  (7 days, a constant in analysis-core) only when there is none: 410
  within it, 404 after. A result kept longer is still answered, so
  pdf-export checks only the token's form, and the --retention setting
  is gone.
- A malformed token is the service's catch-all 500, in its JSON form.
- found/interactors with none is a 404, with or without interactors.
- Neither the summary nor result.json carries the found count; the
  found identifiers' CSV does, from the same set as today's book.

Also records #111's three low review findings under T008.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- pathwaysFound follows the analysis's includeDisease (229 with, 191
  without here); it is asked for with includeDisease=true, as today's
  book counts the unfiltered list.
- How long a result is kept is the service's own cleanup (by the
  results folder's size and last access), recorded as such; the 7 days
  only tell 410 from 404.
- The malformed-token rule is now the form the service issues: wrong
  padding (QQ=) and '/' (a 400 page, or another route) were missed.
- R6's older text, which contradicted the measurement, is corrected;
  the boundary (whole days, future-dated is 410), the time zone, the
  CSV's header and the help-desk placeholder are stated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…'s counts

- Base64 of '_' alone passed the form rule and the service fails on it
  (500); the rule now also requires the decoded {14 digits}_{digits}.
- Today's book counts after its own species and resource filter, not
  the stored list: recorded, with the edge for a pathway without a
  p-value, left to the comparison (FR-012).
- Results are also removed outside the service's cleanup, access times
  depend on the mount, and a resubmission can bring a token back.
- Spec 002: "410 for one a release deleted" corrected; whether its
  report checks the token's form is left to its tasks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…unts

- The token's counter is bounded to 1-19 digits (a Java long): a
  7,000-digit one passed the rule and reached the servlet container's
  HTML 400.
- Today's book counts over every species (its resource filter writes
  back across species); the pathways hit match pathwaysFound with
  includeDisease=true, and the p-value edge belongs to the identifiers
  count, as spec 002 already says.
- A found/... 404 may mean the result went mid-PDF; T010 gains a
  non-JSON 400 and the right reason for its 500; the instance's ASCII
  dates are recorded; spec 002's paragraph and parentheses tidied.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- The bound is on the decoded token, so one nested in %25 layers passed
  the rule and, sent as given, reached the servlet container's HTML
  400; pdf-export sends the canonical token (padded Base64, = as %3D).
- The p-value wording agrees with spec 002's; the calendar is named
  beside the digits; the CSV's file name is a constant.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- T020 (the analysis client) now carries T009's counts, the canonical
  token and each call's Accept header: the CSV endpoint answers the
  framework's own 406 to Accept: application/json alone.
- /token/{token} is paged to one pathway (1 KB, not 94 KB).
- Spec 002: its service contract's 410 row corrected, and its open item
  names the canonical token and Accept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- T010's stub answers a summary whose pathway count follows
  includeDisease, so T020's test fails for a client that leaves it out;
  a found/entities 404 and later 410s are stubbed.
- A later 410, or a 404 from the CSV, ends the PDF as gone-token or
  unknown-token; a found/... 404 stays "none".
- A missing Accept is answered, as the service answers it; only
  application/json alone gets the 406.
- The identifiers-found difference is among FR-012's expected ones.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@adamjohnwright

Copy link
Copy Markdown
Contributor Author

Closed after its review: T010's recorded CSV maps each identifier once, so a client counting rows rather than distinct identifiers would pass. Replaced by a new PR.

adamjohnwright added a commit that referenced this pull request Nov 3, 2026
Spec 001 T009: the analysis service's answers, measured (replaces #118)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant