Repository navigation
Spec 001 T007: a single event's PDF, stage by stage, cold - #96
Closed
adamjohnwright wants to merge 1 commit into
Closed
adamjohnwright wants to merge 1 commit into
adamjohnwright wants to merge 1 commit into
Conversation
Each event of the baseline's sample, at depth 1, in a render service of its own at the website settings with a fresh cache key and the release's files read locally (RENDER_FILES). Figures alone exceed event-pdf's whole time for every reaction (2.6 s against 0.5-1.7 s) and every pathway but Signal Transduction (32.9 s against 46 s); one figure with an analysis token takes 4.5 s, and 19.6 s for the last of eight at once. SC-005 is raised with the user. Script ci/measure/single.ts, outputs in ci/measure/results/. Also: `figures` requires a render service reading the release's files locally (WebsiteAngular #777) and refuses one that does not; R7 records that T005's pathway timings included fetches from the public download site; T005 and T006 carry their PR number, #95. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Replaced by the follow-up PR with this review's findings fixed and SC-005 decided. |
adamjohnwright
added a commit
that referenced
this pull request
Nov 2, 2026
…ided (#102) T007 measured each event of the event-pdf baseline's sample at depth 1, cold, in a render service of its own reading the release's files locally (RENDER_FILES): figures alone exceed event-pdf's whole time for every reaction and every pathway but Signal Transduction; one figure with an analysis token takes 4.6 s, 18.7 s for the last of eight at once. Script ci/measure/single.ts, outputs in ci/measure/results/. SC-005, left to us by the user: a human event's PDF without an analysis reads its figures from the release's figures' folder and keeps event-pdf's times; one with an analysis, of another species, or while the folder is missing or stale, draws them on request within 8 s plus 3 s per figure. T047 wires the folder into the service after T024; T023 measures it after T046 and T047. `figures` refuses a render service not reading local files. Reviewed through #96-#101. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spec 001, T007 (with T005's (c)).
Measured each event of the
event-pdfbaseline's sample at depth 1 on this host. Each ran in a render service of its own:RENDER_FILES(WebsiteAngular #777).event-pdf(s)event-pdf's whole time for every reaction and every pathway but Signal Transduction. SC-005 is raised with the user.ci/measure/single.ts; outputs inci/measure/results/2026-11-02/single/.Also in this PR:
figuresrequires a render service reading the release's files locally, and refuses one that does not (contracts/render.md, T046, T042, R10).RENDER_FILESexisted.🤖 Generated with Claude Code