Repository navigation
fix(player): restore compressor settings on player creation - #3241
Merged
fire-light42 merged 1 commit intoOct 9, 2026
Merged
Conversation
SamoTech
force-pushed
the
fix/restore-compressor-settings
branch
2 times, most recently
from
October 7, 2026 12:06
dcebbc1 to
b1831d8
Compare
SamoTech
force-pushed
the
fix/restore-compressor-settings
branch
from
October 7, 2026 12:06
b1831d8 to
e7d1888
Compare
fire-light42
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the dynamic range compressor settings not being reliably restored when a new player instance is created.
The compressor is created during player/renderers initialization, while the existing UI restoration path can run before the compressor is available. This can leave a newly created player using default compressor values instead of the user's saved settings.
This change:
DynamicRangeCompressoris created.DynamicRangeCompressor.FullScreenPlayer.Related issue: #3237
Why?
A new player instance should behave consistently with the user's previously selected compressor settings. Restoring the values at compressor creation makes the behavior independent of the UI binding lifecycle.
Testing
I performed a static review of the final diff and verified that the branch is based directly on
master.I was not able to obtain a local Gradle build result before opening this PR, so I am not claiming the project build has passed locally. The repository's pull-request CI should provide the authoritative build, lint, ABI, and check results.
AI disclosure
This change was developed with AI assistance. I reviewed the relevant player lifecycle, compressor implementation, existing persistence logic, repository contribution policy, and final diff before preparing the PR.