Repository navigation
Return node when node mutated in place, so change is recorded - #418
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two rules mutate the AST in place and then
return nullon a branch. With the rector-src engine change in rectorphp/rector-src#8791, a pass that records no change skips the format-preserving print, so the in-place mutation is dropped and no longer applied.Fix: return the already-mutated node (or report via the method return value) so the change is recorded. Output is identical - only the return value changes.
DowngradeTrailingCommasInParamUseRector: a closure with a trailing comma in itsuselist but no params ranprocessUses()(which removes the comma via the token stream) but then returned the result ofprocessParams(), which isnullwhen there are no params. Track ahasChangedflag and return the node when eitheruseor param list was cleaned.DowngradeArbitraryExpressionsSupportRector:refactorAssign()removes redundant parentheses around an allowednew/instanceofclass by settingORIGINAL_NODEto null, thencontinues and falls through toreturn null. Track ahasChangedflag and return[$expression]when parentheses were removed in place.Tested green against both rector-src main and the rectorphp/rector-src#8791 branch.