Repository navigation
Proper fix to handle ClassReflection refresh on ClassLike changed - #8728
Merged
Merged
Conversation
Member
Author
|
All green 🎉 @TomasVotruba I am merging it ;) |
Member
|
Thanks 👍 Can you add a little bench test before/after this? AST resolver might a quite expensive. |
Member
Author
|
I will try, it still has another infinite loop tho, I am continuing on then I can create a benchmark for it. |
Member
Author
|
@TomasVotruba rector-drupal now green 🎉 https://github.com/rectorphp/rector-src/actions/runs/39443715849/job/118701428268
|
2 tasks done
Member
Author
|
I improved performance of ClassReflection refresh and add script benchmark on: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

@TomasVotruba here should be proper fix to fix infinite loop on rector-laravel and drupal-rector:
The issue was the rules there tried to resolve from
ClassReflectionwhich not refreshed to due the idempoten.This PR try to fix it with added test for it 👍