Repository navigation
Check the configuration cache only in the main process - #8851
Merged
samsonasik merged 2 commits intoOct 26, 2026
Merged
Conversation
The parallel workers share the cache directory of the main process. A worker that sees a changed configuration clears the whole cache, and deletes files that the other workers write at the same time.
The second run must keep the cache. On 2.8.0 it did not.
Member
|
@SanderMuller not yet, feel free to add it 👍 |
Contributor
Author
Added! |
samsonasik
approved these changes
Oct 26, 2026
Member
|
Let's give it a try, thank you @SanderMuller |
Member
|
Thank you 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #8850.
Each parallel worker runs the configuration check when it boots. If its hash differs from the main process, it clears the whole cache while other workers write to it. On 2.8.0 that sometimes crashed the run. Now only the main process runs the check, before the workers start.
Tested on CodeIgniter4 with 2.8.0 without #8850: a warm run takes about 0.9 s instead of 10 s.
The new workflow runs the compiled
rector/rector:dev-maintwice on a small project and fails if the second run clears the cache. It runs after each merge and daily, because the compiled build only exists after a merge. On my fork it fails with 2.8.0 and passes with 2.7.0 and dev-main: https://github.com/SanderMuller/rector-src/actions/runs/40331633254