Repository navigation
Use active voice and improve rule definitions - #8854
Closed
simonschaufi wants to merge 1 commit into
Closed
simonschaufi wants to merge 1 commit into
simonschaufi wants to merge 1 commit into
Conversation
Rename: - "Changes" to "Change" - "Renames" to "Rename" - "Removes" to "Remove" - "Shortens" to "Shorten" Improve a few rule definitions and apply code style formatting for php methods
Member
|
Same as the other PR. |
Contributor
Author
|
Dear @TomasVotruba I have already contributed some PRs in the past that changed the message to active voice and they all got merged without any complains, see #7146 #6907 #6897. Back then you even commented:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some messages are in active voice and some are in "this rule does this" voice. Make it consistent with this commit.
You may not see a big benefit but for me this is really important as I have a tool where I extract the rule definitions and I need consistency there so I ask you kindly to do me a favor and merge this one. Additionally your docs rendering improves as it prints code nicely on your website 👍
Rename:
Improve a few rule definitions and apply code style formatting for php methods.