[ondrejmirtes]

BetterPhpDocParser does not extend PhpDocParser now. It calls PhpDocParser::parse(), then runs the node decorators. Before, it called the private parseChild() method with PrivatesAccessor.

• Tag positions come from the START_INDEX and END_INDEX attributes of phpdoc-parser.
• CloningPhpDocNodeVisitor is replaced with CloningVisitor from phpdoc-parser.

Fixed: tags after an inline tag were lost

Before, this docblock ended at @internal Use. The parser did not see @var string:

/**
 * @internal Use @see \Rector\Config\RectorConfig::paths() instead
 * @var string
 */

PhpDocParser::parse() continues after a generic tag value, so all tags are found now. Because of this, RemoveUselessVarTagRector now removes 24 @var string tags from typed constants in src/Configuration/Option.php. The new fixture after_inline_tag.php.inc covers this.

Invalid Doctrine annotation

For an invalid annotation such as @\Doctrine\ORM\Mapping\Table('user'), parse() throws ParserException. Rector then keeps the docblock as one text node and does not change it. phpstan/phpdoc-parser#335 fixes this in phpdoc-parser.

Fixed: crash on incomplete Doctrine annotation

@ORM\Table('user', indexes={ @ORM\Index(...) }) with a single-quoted argument gets InvalidTagValueNode. Its value ends before the nested @ORM\Index lines. NestedAnnotationToAttributeRector then threw ShouldNotHappenException.

Now DoctrineAnnotationDecorator keeps such annotation and the next children unchanged until the brackets close. The new fixture skip_single_quoted_alias.php.inc covers this.

This also makes phpstan/phpdoc-parser#335 pass with Rector.

[TomasVotruba]

Thank you 👌