Repository navigation
Allow clean with invalid module graphs - #8640
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1c1a738fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
|
Developer playground preview: https://rescript-lang.github.io/rescript/dev-playground/?version=pr-8640 |
f1c1a73 to
96c35a5
Compare
766e69a to
35b5524
Compare
0d7a3c2 to
9ac4780
Compare
35b5524 to
60b4bb6
Compare
9ac4780 to
0175386
Compare
60b4bb6 to
5cea2cf
Compare
0175386 to
b81ba05
Compare
5cea2cf to
7132187
Compare
b81ba05 to
3102f42
Compare
7132187 to
a32a29e
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
f9b34b1 to
7795392
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Verdict: approve with nits. No correctness bugs found. Dropping
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8640 +/- ##
=======================================
Coverage 81.13% 81.13%
=======================================
Files 456 456
Lines 63750 63750
=======================================
Hits 51724 51724
Misses 12026 12026 🚀 New features to boost your workflow:
|
|
Added the cross-package regression in |
cknitt
left a comment
cknitt
left a comment
There was a problem hiding this comment.
Checked against current master: on master, clean still aborts on duplicate modules, leaves one output when two non-namespaced packages share a module name, never removes out-of-source outputs, and fails without a findable runtime. With this PR all four cases clean correctly. This matches what the OCaml implementation already does. LGTM.
Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
39f1863 to
29a5551
Compare
Restore the changelog fragment, duplicate-package regression, and progress suffix list that were lost during the rebase. Cleanup behavior matches the approved revision while retaining master's remove_js_file rename and suite updates. Validation: Fresh Rust build, all 146 unit tests, all six cleanup integration tests, Clippy, Rust formatting, shell syntax, and changelog validation pass. Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
The parity suite still expected Rust cleanup to panic without a compiler, reject a missing runtime, and leave generated files after duplicate-module errors. Require successful cleanup in both implementations and removal of both duplicate outputs. Remove the obsolete out-of-source cleanup difference from the OCaml build-system guide. Validation: Fresh Rust build, five focused command-parity cases from the CI script, all six cleanup integration tests for each CLI, canonical suite coverage, shell syntax, changelog validation, and whitespace checks pass. Signed-off-by: Florian Hammerschmidt <florianh89@gmail.com>
2 participants
Summary
rescript cleanconstructed the build graph before removing generated JavaScript. Duplicate module names or another invalid source state could therefore abort cleanup and leave files behind.Derive both in-source and out-of-source outputs directly from discovered package source files so cleanup does not require compiler discovery or a valid module graph. This also removes generated
lib/es6andlib/jsoutputs in the project and its dependencies, including dependencies undernode_modules. The progress message lists suffixes from all configured package outputs. Cleaning also removes outputs from every package when non-namespaced dependencies share a module name.Validation
make test-rewatchFoo.mjsoutputs exist, then checks root cleanup removes both. It passes with this PR and fails with the previous cleanup implementation, which leaves one output behind.cargo test --manifest-path rewatch/Cargo.tomlcargo clippy --manifest-path rewatch/Cargo.toml --all-targets --all-featuresmake checkformat