Repository navigation
lancedb: drop the 0.40.0 patches - #4140
Merged
Merged
Conversation
0.40.0 was already declared on main and built without them; the nightly run copied them again because its stale package branch did not have the version.
The package branch is no longer rebased while its PR is open, so --declare can add a version that main already has (and built without patches), then copy the previous version's patches for it. Take the base copy of the package YAML with --base-file, like pending_versions.py, and skip the copy for versions it declares. The nightly job passes main's copy.
luhenry
force-pushed
the
lancedb-revert-patches
branch
from
October 30, 2026 09:43
128616b to
c3e7cf0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.40.0 was already declared on main and built without them; the nightly run
copied them again because its stale package branch did not have the version.