Skip to content

fix(lint): respect explicit projectService settings - #561

Merged
chenjiahan merged 1 commit into
mainfrom
fix-lint-project-service
Oct 10, 2026
Merged

chenjiahan merged 1 commit into
mainfrom
fix-lint-project-service

Conversation

@elecmonkey

Copy link
Copy Markdown
Member

Motivation

Rstack injects project: ['./tsconfig.json'] when no explicit project is configured and a tsconfig exists in the current directory. This conflicts with projectService: true, even when the two options come from different config entries.

Changes

Only inject the default project when neither project nor projectService is explicitly configured. This respects both enabled and disabled service settings while preserving the existing fallback for configs that omit both options.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying rstack-cli with  Cloudflare Pages  Cloudflare Pages

Latest commit: 10ed515
Status: ✅  Deploy successful!
Preview URL: https://5df503bf.rstack-cli.pages.dev
Branch Preview URL: https://fix-lint-project-service.rstack-cli.pages.dev

View logs

@chenjiahan chenjiahan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@chenjiahan
chenjiahan merged commit 0c156ff into main Oct 10, 2026
5 checks passed
@chenjiahan
chenjiahan deleted the fix-lint-project-service branch October 10, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants