Repository navigation
fix(lint): respect explicit projectService settings - #561
Merged
Merged
Conversation
Deploying rstack-cli with
|
| Latest commit: |
10ed515
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5df503bf.rstack-cli.pages.dev |
| Branch Preview URL: | https://fix-lint-project-service.rstack-cli.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Rstack injects
project: ['./tsconfig.json']when no explicitprojectis configured and a tsconfig exists in the current directory. This conflicts withprojectService: true, even when the two options come from different config entries.Changes
Only inject the default project when neither
projectnorprojectServiceis explicitly configured. This respects both enabled and disabled service settings while preserving the existing fallback for configs that omit both options.