Repository navigation
feat(create-rstack): add pnpm workspace template - #580
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying rstack-cli with
|
| Latest commit: |
44f1084
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fa10d2a1.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-feat-pnpm-workspa.rstack-cli.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Provide a minimal monorepo starter for users who want pnpm workspaces without an additional task orchestrator.
Changes
Add a
pnpmtemplate with a React application and shared UI library, listed before Turborepo in the monorepo selector. Build packages in dependency order and build shared libraries before starting development watchers or running tests. Update scaffold coverage and the English and Chinese template lists.Validated a fresh generated project: installation, tests without existing build output, builds, checks, and browser rendering, interaction, and app/shared-library hot updates. Repository build, native build,
pnpm check, all 34 scaffold tests, and changed-file spelling checks passed.