Repository navigation
Conversation
`test_no_memory_leak` fails on `ubuntu-latest 3.3` in CI:
<2441216> was expected to be less than
<2400000>.
This isn't a leak. The RSS grows only once, and it doesn't depend on
the number of calls.
`assert_nothing_leaked_memory` runs the block right after `GC.start`.
`GC.start` resets the malloc increase counters, so the next GC comes
later and the block can raise the peak malloc usage. The process keeps
that peak in RSS. The warm up loop doesn't run right after `GC.start`,
so it doesn't reach the same peak.
Run `GC.start` before the warm up loop too. With this change, the RSS
growth in the block is 0 in 10 of 10 runs locally. Without it, the
growth is 1.4 MB to 1.5 MB in 6 of 10 runs.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Print RSS details from `/proc/self/status`, some `GC.stat` values and `malloc_stats()` at each stage of `test_no_memory_leak`. The test fails on CI with Ruby 3.1 but it doesn't fail locally. This is temporary and will be removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kou
marked this pull request as draft
October 12, 2026 21:23
Member
Author
|
This doesn't fix the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_no_memory_leakfails onubuntu-latest 3.3in CI:This isn't a leak. The RSS grows only once, and it doesn't depend on the number of calls.
assert_nothing_leaked_memoryruns the block right afterGC.start.GC.startresets the malloc increase counters, so the next GC comes later and the block can raise the peak malloc usage. The process keeps that peak in RSS. The warm up loop doesn't run right afterGC.start, so it doesn't reach the same peak.Run
GC.startbefore the warm up loop too. With this change, the RSS growth in the block is 0 in 10 of 10 runs locally. Without it, the growth is 1.4 MB to 1.5 MB in 6 of 10 runs.