Repository navigation
Conversation
Member
|
Change by change explanation:
The production numbers are good to hear about, but with five changes in one PR plus your own cleaner job, there's no way to tell which change did it. If you can reproduce a leak while calling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Browser shutdown does not always release all resources. Depending on the failure path, Chromium processes or their child processes may remain alive, temporary files may be left behind, and WebSocket resources may not be fully closed.
There is also a problem with garbage-collection cleanup: a Browser finalizer may run in a context where thread synchronization and thread operations are not allowed, causing cleanup to fail.
Changes
This PR addresses these issues across the browser, process, client, and WebSocket cleanup paths.
Errno::ECHILD), so surviving child processes are not left running.Regression tests cover the corresponding failure scenarios.
Production verification
After deploying these changes, the SpaceCleaner report has shown zero leftover Chromium processes and zero leftover Ferrum/Chromium temporary-directory entries for two consecutive days.
This provides practical confirmation that the original production problem has been addressed.