Repository navigation
feat(events): run on(:request), on(:auth) and on(:dialog) callbacks as a chain - #703
Merged
Merged
Conversation
…s a chain Callbacks run in the order they were added and stop at the first one that handles the object (continue, respond, abort, accept, dismiss), so a callback that doesn't care just returns. An object nobody handled is continued, an auth challenge gets Chrome's default response, and a dialog is accepted with a warning. Callbacks receive only the object, not index and total, which also makes page.on(:request, &:continue) work. InterceptedRequest, AuthRequest and Dialog get handled?.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the
(object, index, total)callback shape with a chain of responsibility. Supersedes #701.continue,respondorabortfor a request,continueorabortfor an auth challenge,acceptordismissfor a dialog. A callback that doesn't care just returns.page.on(:request, &:continue)works now, it used to callcontinue(index, total).InterceptedRequest#handled?,AuthRequest#handled?andDialog#handled?tell whether a previous callback took the object.Network#authorizeand the proxy authorization no longer count callbacks to decide what to do.Breaking:
indexandtotalarenilfor blocks that still take them, a lambda taking three arguments raises.(params, index, total).