Repository navigation
fix(worker): close a dedicated worker from inside, Chrome refuses Target.closeTarget for it - #704
Merged
Merged
Conversation
…get.closeTarget for it
route
force-pushed
the
fix/dedicated-worker-close
branch
from
November 15, 2026 11:25
54585b6 to
1f52a66
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worker#closesentTarget.closeTargetasynchronously and returnedtrue. Chrome answersSpecified target doesn't support closingfor dedicated workers, and the error was swallowed, so the worker stayed alive.Shared and service workers close fine with
Target.closeTarget, so only dedicated workers change:closenow evaluatesself.close()inside the worker, still async to avoid waiting on a session that goes away.Workertakes atype:from its target to pick the path.The new
#closespec fails without the fix.