Repository navigation
fix(page): call client.command inside wait_for_navigation! so a command override runs once - #706
Merged
Merged
Conversation
…nd override runs once Page#command(wait:) called command again in the block, which ran a subclass override such as Cuprite's twice. Call client.command there, after the slowmo sleep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Page#command(wait:)calledcommandagain insidewait_for_navigation!, so a subclass that overridescommand, like Cuprite'sPage, ran its override twice for a waiting command.The block now calls
client.commanddirectly, after the slowmo sleep. The sleep moves out of the wait, so it runs once before navigation tracking starts.