Repository navigation
Wait for Apple connection completion in connect_timeout - #680
Open
RanaPriyansh wants to merge 3 commits into
Open
RanaPriyansh wants to merge 3 commits into
RanaPriyansh wants to merge 3 commits into
Conversation
chansuke
reviewed
Oct 21, 2026
|
|
||
| match res { | ||
| Ok(()) => return Ok(()), | ||
| Ok(()) => { |
Contributor
There was a problem hiding this comment.
could we keep the comment from #669 explaining why this exists? without it, Ok(()) falling through to poll looks like a bug imho
Author
There was a problem hiding this comment.
Thanks for raising this. I restored the rationale from #669 above the Apple-specific path: a successful non-blocking connect can precede completion, so Apple targets continue to poll_connect. This change restores the comment only and adds no runtime evidence.
Codex used.
BiagioFesta
approved these changes
Oct 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revives the Apple completion check from #669 for #652, with additional validation.
On Apple targets, continue through the existing completion poll after
connectsucceeds. Keep immediate success on other targets. Extend the loopback test to check IPv4 and IPv6 peer identity, accepted data, and blocking-mode restoration. The IPv6 loopback check skips Redox and Vita.A private syscall-interposition probe calls the public API: baseline returns
Okwithout polling; candidate returnsTimedOutafter one target poll. Both pass a non-target loopback transfer. This checks dispatch; the reported VPN setup was not reproduced.The default
cargo test --all-featurescommand failed on both baseline and candidate because existingqnxcfg diagnostics are denied during tests. Successful local macOS checks declared this existing cfg with--check-cfg=cfg(target_os,values("qnx")). Blocking mode was observed only on local macOS. The local checks do not establish other-platform runtime behavior or the reported VPN configuration. All 58 reported hosted checks passed on prior head9a39af9efbb9f1c38c47d5aacec7f570a12ac3d3in CI run 39505258595. That head predates this comment-only follow-up. Cross-target compilation does not establish runtime execution on each target.Codex used.