Repository navigation
Match Windows global graph lanes to macOS - #920
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bring the Windows cross-project Graph overview closer to the macOS lane model without changing the daemon protocol or shared graph model.
Addresses #724.
Changes
Test plan
RED:
$env:GRAPHCODE_ZIG0152 test src\GraphCanvas.zig -target x86_64-windows-msvc -lc -luser32 -lgdi32 -lgdiplus --test-filter overview-> 16 passed, 1 skipped, 2 failed; project caption returned null and shared START was absentGREEN:
$env:GRAPHCODE_ZIG0152 test src\GraphCanvas.zig -target x86_64-windows-msvc -lc -luser32 -lgdi32 -lgdiplus --test-filter overview-> 21 passed, 1 skipped, 0 failedREGRESSION:
$env:GRAPHCODE_ZIG0152 test src\App.zig src\AccessibilityProvider.cpp src\FilePicker.c src\FolderPicker.c winghostty-win32-host.lib -target x86_64-windows-msvc -lc -luser32 -lgdi32 -lgdiplus -lmsimg32 -lopengl32 -lkernel32 -limm32 -lole32 -loleaut32 -luiautomationcore -lshell32 -ladvapi32 -lwinhttp ghostty-vt-static.lib-> 1556 passed, 17 skipped, 0 failedAdditional local evidence:
pwsh -NoProfile -File Tools\windows\Tests\ValidationRunner.Tests.ps1: UiScenario 166 passed, 0 failed; UiCaptureDriver 182 passed, 0 failedpwsh -NoProfile -File Tools\windows\validate.ps1 -Task windows-shell -SkipTrayLive -ShellValidationRoot C:\g -SwiftExecutable C:\Users\coneilen\AppData\Local\Programs\Swift\Toolchains\6.3.3+Asserts\usr\bin\swift.exe: unit executables, native accessibility checks, provider builds, shell build/smoke/restart, scrubbed startup, daemon round trip, and profile isolation passedpwsh -NoProfile -File Tools\windows\validate.ps1 -Task windows-shell -ShellPart integration -SkipTrayLive -ShellValidationRoot C:\g -SwiftExecutable C:\Users\coneilen\AppData\Local\Programs\Swift\Toolchains\6.3.3+Asserts\usr\bin\swift.exe: passed; native UIA opened the exact overview caption, preserved normalized project/overview geometry, and reportedlegacyChipCount: 0Evidence limits:
Checklist
git commit -s) per the DCOmake test)make check)