Skip to content

Match Windows global graph lanes to macOS - #920

Merged
coneilen merged 2 commits into
mainfrom
coneilen-global-graph-724
Oct 24, 2026
Merged

coneilen merged 2 commits into
mainfrom
coneilen-global-graph-724

Conversation

@coneilen

Copy link
Copy Markdown
Collaborator

Summary

Bring the Windows cross-project Graph overview closer to the macOS lane model without changing the daemon protocol or shared graph model.

Addresses #724.

Changes

  • draw one shared START marker with tethers only to lanes that have entry or unwired roots
  • replace permanent per-lane Open/Worktrees buttons with caption-wide project navigation and optional observed local worktree chips
  • add macOS-style lane names and presence-aware aggregate or entry-point captions
  • filter an empty global graph from overview emptiness while retaining empty ordinary project lanes
  • publish distinct overview project/chip accessibility identities and preserve exact card project/node navigation
  • keep remote/global worktree actions absent and keep spawn-target metadata from creating cross-lane connectors

Test plan

RED: $env:GRAPHCODE_ZIG0152 test src\GraphCanvas.zig -target x86_64-windows-msvc -lc -luser32 -lgdi32 -lgdiplus --test-filter overview -> 16 passed, 1 skipped, 2 failed; project caption returned null and shared START was absent
GREEN: $env:GRAPHCODE_ZIG0152 test src\GraphCanvas.zig -target x86_64-windows-msvc -lc -luser32 -lgdi32 -lgdiplus --test-filter overview -> 21 passed, 1 skipped, 0 failed
REGRESSION: $env:GRAPHCODE_ZIG0152 test src\App.zig src\AccessibilityProvider.cpp src\FilePicker.c src\FolderPicker.c winghostty-win32-host.lib -target x86_64-windows-msvc -lc -luser32 -lgdi32 -lgdiplus -lmsimg32 -lopengl32 -lkernel32 -limm32 -lole32 -loleaut32 -luiautomationcore -lshell32 -ladvapi32 -lwinhttp ghostty-vt-static.lib -> 1556 passed, 17 skipped, 0 failed

Additional local evidence:

  • focused App overview filter: 30 passed, 1 skipped, 0 failed
  • focused LaneLayout overview contract: 1 passed, 0 failed
  • full GraphCanvas executable: 406 passed, 17 skipped, 0 failed
  • full App executable: 1556 passed, 17 skipped, 0 failed
  • pwsh -NoProfile -File Tools\windows\Tests\ValidationRunner.Tests.ps1: UiScenario 166 passed, 0 failed; UiCaptureDriver 182 passed, 0 failed
  • pwsh -NoProfile -File Tools\windows\validate.ps1 -Task windows-shell -SkipTrayLive -ShellValidationRoot C:\g -SwiftExecutable C:\Users\coneilen\AppData\Local\Programs\Swift\Toolchains\6.3.3+Asserts\usr\bin\swift.exe: unit executables, native accessibility checks, provider builds, shell build/smoke/restart, scrubbed startup, daemon round trip, and profile isolation passed
  • pwsh -NoProfile -File Tools\windows\validate.ps1 -Task windows-shell -ShellPart integration -SkipTrayLive -ShellValidationRoot C:\g -SwiftExecutable C:\Users\coneilen\AppData\Local\Programs\Swift\Toolchains\6.3.3+Asserts\usr\bin\swift.exe: passed; native UIA opened the exact overview caption, preserved normalized project/overview geometry, and reported legacyChipCount: 0

Evidence limits:

Checklist

  • I have read the Contributing Guidelines
  • I have signed off my commits (git commit -s) per the DCO
  • Tests pass locally (make test)
  • Code follows the existing style (make check)
  • I added the test/contract before the implementation and observed the intended RED failure

coneilen and others added 2 commits October 23, 2026 19:11
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Colin Neilens <coneilen@microsoft.com>
@coneilen
coneilen merged commit 6c15f2f into main Oct 24, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant