Repository navigation
Integration merge queue - #1261
Conversation
|
Thanks for creating this PR. I wasn’t sure how to set up merge_group, so I couldn’t create the PR myself. 😂 I’ve reviewed the PR, and the changes match what I had in mind. Do we also need to require the merge queue for master and add integration-gate as a required status check? I also have one question about the current setup. I noticed that the pytest step in MacOS-test is commented out. Since the goal is to catch platform-specific test failures before merging, is there a reason why it is disabled? |
I think so, to run the tests at merge time.
I don't quite remember, but I think it was either because it was too slow, or because it was constantly failing and we could not reproduce the error. |
An attempt to fix #1249
@MySweetEden , can you please try to take a look at this?