Skip to content

fork-changes-list: fail on unusual forkDefaults row shapes (#389 follow-ups) #396

Closed

Description

@scuttletoby

Follow-ups from the lens on #389 (#389 (comment)).

  1. minor: .github/scripts/fork-changes-list.cjs:30-33 reads forkDefaults.ts as text and only counts scope:. These row shapes are skipped silently, so a setting written that way could be missing from FORK_CHANGES.md with no red test: a spread (...EXTRA_ROWS), a helper call (row("server", "x")), shorthand { scope, key: ... }, a ]; at column 0 inside a row (ends the table early). (Quoted or spaced scope is rewritten by the formatter.) Today's table is uniform (22 of 22 read), so nothing is missed now. Fix: reject any entry at row level in the table that is not a { ... } object literal; a test row for each shape, red first.
  2. nit: .github/scripts/fork-owned-reads.test.py:62 filter "*" not in l does nothing (names compare exactly): drop it or make it mean something.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions