You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fork_checks_ran / contract: budget margin, named FAILs, a test for the name guard (#445 lens follow-ups) #449
minor.github/scripts/fork-contracts.test.py:1705: the budget check passes when the worst case equals the job timeout exactly (checkout timeout-minutes: 4 gives 4 + 10 + 1 = 15 of 15 min), leaving no time for job set-up, so a worst-case run is cancelled before the pull_request_target is blocked by default on public repos from 2026-12-02: keep fork checks running #401 message (still fails closed). Fix: strict < or a small margin; test the 4-minute case red.
nit the 3 contract mutants caught only by a TypeError at :1705 (missing / non-int checkout timeout): give a named FAIL instead of a crash, so the later checks and cleanup still run.
nit.github/scripts/fork-checks-ran.py:153: the head_repository.full_name == GITHUB_REPOSITORY guard has no test (the repo-id match covers it). Keep it; add one test with a foreign name but this repo's id.
nit (docs)fork-checks-ran.py:16-17 Limits: also name a PR closed and a new one opened from the same branch at the same commit (old runs list the new PR until its own run exists; needs write access, so inside the existing limit).
State question for the fix: re-run, PRs opened before the fix (their next run uses main's contract), a checkout timeout changed in the same PR as the contract.
Activity
fork-ci: fork_checks_ran budget margin, named contract FAILs, name-gu…
fork-ci: fork_checks_ran budget margin, named contract FAILs, name-gu…
fork-ci: fork_checks_ran budget margin, named contract FAILs, name-gu…