You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
seam check: verify promoted lines against upstream in CI #552
When a pull request moves a pending file to files (a declared seam), the pull request's seam-check run has no upstream, so it checks only how many lines the new entry lists and that the file has them, not that they are the fork's lines. A wrong entry is refused later by fork-follow's run on main (it fails closed), and until then the owner checks it by hand with the --from-upstream command in docs/fork/updates.md.
Proposal: in fork-checks, fetch upstream's default branch read-only (as fork-follow already does), take git merge-base <default branch head> <upstream head> as the upstream commit, and pass it to the checker (for example --upstream-base <rev>). For each moved file, require the entry's added to equal the head's fork lines counted from that commit exactly. If the fetch fails, keep today's behaviour and print a note.
Activity
fork seam check: review follow-ups for moving a pending file to a seam
fork seam check: allow promoting a pending file to a declared seam (#549