Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 12 additions & 16 deletions .github/fork-seams.json
Original file line number Diff line number Diff line change
Expand Up @@ -120,22 +120,18 @@
},
"apps/server/src/peer/RemoteDelegation.ts": {
"why": "#386: a remote delegate_task interrupted after its launch there (the parent's turn moved on) still records and follows its task: the launch, record and follow run as one uninterruptible step. A launch recorded with no task here is stopped there with a warning, as a failed record is. Tested in apps/server/src/fork/remoteDelegationAbortSafe.test.ts. Upstream PR pingdotgg/t3code#30249 (record before launch) rewrites this block, and its intent differs: after an interrupted, uncertain launch it stops the child there, while this seam keeps the child and follows it. Whoever brings #30249 in through fork-follow must choose on purpose between stopping and keeping (and expect a merge conflict on this block), then drop this seam or keep it.",
"added": [],
"announced": {
"since": "2026-11-18",
"added": [
"// Fork: from the launch on, the task is recorded and followed even if this call is",
"// interrupted (the parent's turn moved on), else the thread there runs with nothing here",
"// following it or reporting its end. The reads above stay cancellable.",
"// prettier-ignore",
"return yield* Effect.gen(function* () { // Fork: start of launchAndRecord.",
"}).pipe(Effect.uninterruptible); // Fork: end of launchAndRecord.",
"// Fork: nothing here follows it, so stop it there, as a failed record does.",
"yield* Effect.logWarning(\"remote-delegation.record-found-no-task\", remoteChild);",
"const unfollowed = stopThere(followScope(scope.thread, remoteChild), remoteChild, \"stop\");",
"yield* unfollowed.pipe(Effect.ignoreCause({ log: true }));"
]
}
"added": [
"// Fork: from the launch on, the task is recorded and followed even if this call is",
"// interrupted (the parent's turn moved on), else the thread there runs with nothing here",
"// following it or reporting its end. The reads above stay cancellable.",
"// prettier-ignore",
"return yield* Effect.gen(function* () { // Fork: start of launchAndRecord.",
"}).pipe(Effect.uninterruptible); // Fork: end of launchAndRecord.",
"// Fork: nothing here follows it, so stop it there, as a failed record does.",
"yield* Effect.logWarning(\"remote-delegation.record-found-no-task\", remoteChild);",
"const unfollowed = stopThere(followScope(scope.thread, remoteChild), remoteChild, \"stop\");",
"yield* unfollowed.pipe(Effect.ignoreCause({ log: true }));"
]
}
},
"//pending": "Upstream files whose fork lines predate counting every upstream file, each with its ceiling: the most fork lines it may hold against upstream (counted from upstream, as fork-follow runs the check). To move into fork files or pin as seams; lower a ceiling when lines move out and take a file off when none are left. A pull request may change them but not grow them.",
Expand Down
Loading
Loading