Repository navigation
Refs #311, Fixes #325, Fixes #416: seam check follow-ups - #506
Conversation
…ip copies spent - fork-follow commits the list with each "pending" ceiling and "lost" count that fell after a rebase lowered (#325 item 1), checks it again, and names each change in the commit body and the run summary. It never raises one. - fork-seam-check --lowered-list (only with --from-upstream --after-rebase) writes that list; lowerList keeps comments and order and only lowers. - A pull request that removes lines from a "pending" file lowers its ceiling in its own list (#311 comment); its own list is read only for that. - A listed seam copy the base branch's tip has since the merge-base is spent (#311 item 3, as far as code goes). - A file named like an Object property is held to its "lost" count (#416 item 3); the announcement lookup reads own keys too. - Docs: the new rules, #416 item 2, and how the check behaves with a missing, empty or old list, renamed or deleted files, and after a rebase. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lens a (correctness + state), head f952c43Verdict: SAFE WITH NITS. No blocking finding. The lowering only tightens the list, is re-checked, never raises, and fails closed. A run that stops half-way or runs again cannot publish a wrong commit. Ran on the head: Findings
Checked and fine (state question)
|
Lens bVerdict: SAFE WITH NITS Reviewed head Checked and sound
Findings
Nothing here can raise a count, drop a guard or produce a commit the release then trusts wrongly. |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fork seams: lower counts after a rebase, shrink lowers its ceiling, tip copies spent - fork-follow commits the list with each "pending" ceiling and "lost" count that fell after a rebase lowered (#325 item 1), checks it again, and names each change in the commit body and the run summary. It never raises one. - fork-seam-check --lowered-list (only with --from-upstream --after-rebase) writes that list; lowerList keeps comments and order and only lowers. - A pull request that removes lines from a "pending" file lowers its ceiling in its own list (#311 comment); its own list is read only for that. - A listed seam copy the base branch's tip has since the merge-base is spent (#311 item 3, as far as code goes). - A file named like an Object property is held to its "lost" count (#416 item 3); the announcement lookup reads own keys too. - Docs: the new rules, #416 item 2, and how the check behaves with a missing, empty or old list, renamed or deleted files, and after a rebase. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fork seams: shorten comments for the lint rule Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* fork seams: lower counts after a rebase, shrink lowers its ceiling, tip copies spent - fork-follow commits the list with each "pending" ceiling and "lost" count that fell after a rebase lowered (#325 item 1), checks it again, and names each change in the commit body and the run summary. It never raises one. - fork-seam-check --lowered-list (only with --from-upstream --after-rebase) writes that list; lowerList keeps comments and order and only lowers. - A pull request that removes lines from a "pending" file lowers its ceiling in its own list (#311 comment); its own list is read only for that. - A listed seam copy the base branch's tip has since the merge-base is spent (#311 item 3, as far as code goes). - A file named like an Object property is held to its "lost" count (#416 item 3); the announcement lookup reads own keys too. - Docs: the new rules, #416 item 2, and how the check behaves with a missing, empty or old list, renamed or deleted files, and after a rebase. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fork seams: shorten comments for the lint rule Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Refs #311, Fixes #325, Fixes #416
Follow-ups to the seam check (
fork-seam-check.cjs, fork-follow'sseam_check).Item by item
#325
fork seams: lower counts after the rebase onto <tag>. It lowers every "pending" ceiling and "lost" count that fell.fork-seam-check.cjs --lowered-list <path>writes the lowered list. The flag is only accepted with--from-upstream --after-rebase; otherwise it is a usage error, exit 2.lowerListonly lowers. It keeps//comment keys and key order, and checks its output withparseConfig.#311
#416
Math.minbound) and item 4 ("remove it from lost"): already covered by tests on main. Removing either fix turns its test red.constructor,toString,__proto__) readlost[file]from Object's prototype. Its counts were undefined, so every lost line passed. Lookups now useObject.hasOwn, also in the announcement lookup.}), a PR may drop upstream's copy instead of the fork's, and the PR's run passes it. fork-follow, counting from upstream, refuses it unless the lines left read the same as with the fork's copy dropped.Skipped (and why)
strict_required_status_checks_policy: false. So two changes that are fine apart but not together can still both merge without either being updated from main.serverSettings.tslines into fork files): a runtime refactor of how settings load. It belongs in its own PR with its own review.How the check behaves (it is a merge gate)
Missing, empty or unreadable list. All fail closed:
{}(nofiles) or an unknown key (such as a newer check's) stops the run with a crash, exit 3. fork-follow reports that as a failed check and pushes nothing.Old list. A key it lacks (
pending,lost,forkFiles) is empty, which is stricter: every fork line it does not list is refused.Renamed or deleted upstream file.
pendingfile the base lacks is refused.After a rebase.
lostentry still names. A ceiling must be at least 1, and alostentry needs its file listed. That stays a note, the next run refuses it, and the doc says to move the file tofileswith"added": [].Tests
node --test .github/scripts/fork-seam-check.test.cjs: 74 pass (67 before).lowerList; and--lowered-listwriting, writing nothing on a refused run, and its usage errors.findSeamBreaches, the write, raise-guard, per-countmin.bash .github/scripts/fork-follow.test.sh: all pass.candidate=HEADrefresh turns it red, and so does not passing--lowered-list.python3 .github/scripts/fork-contracts.test.py: pass.node --test .github/scripts/fork-ci-tests.test.cjs: pass. It caught a| grep -qin the new shell test, now fixed.vppins. oxlint shows no new warnings.General vs project
All general: the seam check, the list format and fork-follow's lowering work for any fork that keeps a
.github/fork-seams.json. There is nothing project-specific. Paths come from the list and the rebase target.🤖 Generated with Claude Code