Repository navigation
golive: keep fork features as they are across a fork-to-fork switch - #557
Conversation
Review (lens A)Verdict: one BLOCKING finding. A fork-to-fork switch can go live with features changed, because "unchanged" is measured only with the target build, and only by feature name. Checked: check, switch ( BLOCKING
MINOR
On the brief's question, does the rehearsal touch the live home's settings? No. State question:
|
Review (lens B)Head Brief questions:
BLOCKING1. "Unchanged" is read by the target build only, never by the build that is live. MINOR
State question: a switch refused for a changed list changes nothing and a rerun goes through (tested). A rehearsal killed at Verdict: NOT SAFE until 1 is fixed. I rank 1 blocking because fork-to-fork switches are this PR's whole purpose, and |
check recorded "all off" as a hard rule in four places (check, the switch's before step, verify, the rehearsal's R4), so once any fork feature was on no later fork release could go live through the kit. - check records the staged build's featuresOn list in its result. While the live build is upstream (the first switch) every feature must still be off; a report without the list refuses. - switch reads the list again just before the stop (beside the running T3, as check does) and refuses with T3 running when it changed; before and verify require exactly the check's list. - rehearse switches every feature that is on off in the clone's settings.json only (never the home's or the copy's; the restore puts the copy's back), requires a report that says all off before any server starts, and records what it did in a features-off step and the result. Fixes #529 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ad the same (#529) check now also runs the live fork build's own report beside the running T3 and compares the whole feature state (each value, the names on, where) with the staged target's, order-independently. A difference refuses before anything stops, naming each feature. A live fork build without a readable report passes only with all off. The switch's re-read before the stop, `before` and verify compare the same full state. The README says a rehearsal never runs the target with the features that go live. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5162b5b to
383a11d
Compare
Fix roundHead
The rest are listed as follow-ups in the PR body: comparing State question:
Suites on this head, all OK: back 106, check 82, contract 5, copy 108, gap 29, journal 29, rehearse 94, switch 108. To get the old-code results, I ran the new tests and fixture against this branch's lib from before the fix commit: check |
BASE main
Fixes #529
Not stacked. This PR is rebased onto
main, which now includes #554, and merges cleanly with #556. A patch-id comparison shows that only this PR's own commits came over.What
The kit treated "every fork feature off" as a fixed rule in four places: check, the switch's
beforestep, verify, and the rehearsal's R4. So once any fork feature was switched on, no later fork release could go live through the kit. This PR does points (1) and (2) of the issue.features: each value, the names on, and where each one is on, all sorted. A report without the list or the values refuses. While the live build is upstream (its version has no.fork.N: the first switch), every feature must still be off. While it is a fork build, check also runs the live build's own report beside the running T3, and refuses before anything stops unless both builds read the same values in the same places. The refusal names each feature that differs, for example a new feature on by default, orusagePacingGateadvise→enforce. A live fork build that gives no report this kit reads passes only with all off.server_changedafter the read). If anything changed since the check, it refuses with T3 still running.beforeand verify then require exactly the check's full state, not an empty one.features-offstep after the preflight. It switches every feature that is on off in the clone'ssettings.jsononly (never in the live home or the copy; the restore puts the copy's file back). It then needs a report that says all off before any server starts. A feature the machine's policy keeps on, or asettings.jsonthat is not plain JSON, fails the run before R2 and names it. The result records what was switched off and where (featuresOff).Point (3), the update path: this PR keeps the kit as the path for fork-to-fork updates. The alternative is to let a fork build that is already live update itself with upstream's
t3 update, or with the fork'sautomaticUpdates(fork #5). That would skip the kit's check, copy, rehearsal and put-back. It is left as a later choice.State question (tests)
features-offstep, or in the middle of writing the clone's settings, runs again cleanly, and nothing needs settling (StoppedHalfWaycovers both points).[]and passes. A report with nofeaturesOnlist refuses in check, in the switch and in the rehearsal. A missingsettings.jsonwith a feature the policy keeps on fails, and names it.Follow-ups (not in this PR)
featuresOffis not compared with the switch'sfeatures(lens A 3). A rehearsal always runs with every feature off, so it never covers the set that goes live. The README now says so.General vs project
Everything here is general to the kit: the fork report's
featuresOnandfeaturesWhere, the.fork.Nversion form, and the clone'ssettings.json. Nothing names a machine, a project or a feature; the tests use made-up feature lists.Old code
main's lib (back, check, live, rehearse, switch)ForkFeatures(fork build, features on)fork features offFirstSwitchFeatures(feature switched on after the check)ForkFeatures(verify,beforewith features on)FeaturesOfffork features on, nothing switched off in the clonelive.fork_build,rehearse._features_offmainI ran these against
main's lib files with the new tests and fixture. All golive suites pass on this branch: back, check, contract, copy, gap, journal, rehearse and switch.🤖 Generated with Claude Code