Repository navigation
fork(handoff): test a missing thread and unreadable settings; document when neither acts (#586) - #605
Merged
Merged
Conversation
…t when neither acts (#586) Tests: the wrapper's missing-thread and settings-read paths each have their own cases (once, runs again, changed while compaction waits, and back again at the next run), plus an old project override with no handoff key. Docs: say that handoff switched on mid-wait starts at the next turn end, and that a handoff that cannot run also stops idle compaction. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
lens: state + docs accuracy (one lens) verdict: SAFE (head The PR changes only tests and docs; the code is the same as on main (#583, merged). Merging it makes nothing worse. No blocker. There is one major point (one docs claim is wrong) and three minor ones. What I checked
Major
Minor
CI: 🤖 Generated with Claude Code |
… modelSelection A send to a removed provider instance fails before any run, so there is no retry and only a server-log warning. Say which entry wins and where to change modelSelection (review on #605). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
Fix for the review above, head
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #586
The four points from the #583 review (SAFE, minor 1–4).
Docs (
docs/fork/handoff.md, "One owner per thread")modelSelectionpoints at a provider instance that was turned off or removed) also stops idle compaction for that thread. The docs say why it does not grow forever (the size backstop tries again at each turn end, and the provider's own compaction still applies) and how to get compaction back (fixmodelSelection, or set the thread's or project's mode toofforcompact). I chose the docs option over a code change: the issue allows either, and checking the target instance belongs with the settings screen work, so the handoff service and the wrapper keep using one rule.Tests (
handoffOwner.test.ts, upstream's ownIdleCompactionServicebehind the wrapper)findThreadreturns null → upstream decides and compacts.State question, for both paths:
handoffkey uses the server's mode (on → no compaction, off → compacts).Mutation runs (each fails on the old code; run locally):
thread === nullcounted as owned (the reviewer's surviving mutant): 4 tests red.Effect.orDie(serverSettings.getSettings)): 3 tests red.handoffread as off: 1 test red.src/fork/handoff102 of 102 green (was 93). Server typecheck, lint and format are clean.General vs project
General: tests and docs for the fork's handoff add-on, which sits on upstream's own orchestrator and idle compaction. No project facts. Project: none.
🤖 Generated with Claude Code