Repository navigation
feat: accents.json - #368
Merged
Merged
Conversation
✅ Deploy Preview for jade-cajeta-1bcca0 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Zethson
approved these changes
Oct 22, 2026
Zethson
left a comment
Zethson
left a comment
Member
There was a problem hiding this comment.
Much better and will help us with scverse-doc
Zethson
added a commit
to scverse/scverse-doc
that referenced
this pull request
Oct 22, 2026
scverse/scverse.github.io#368 moved the package colours into assets/accents.json and generates the --<pkg>-<colour> properties from it in Sass, so main.scss no longer spells them out and the sync failed with --scverse-deep-blue and --scverse-sky-blue missing. The script now reads accents.json, converts its OKLCH values to sRGB hex, takes each package's first colour as its accent and the second colour for the packages opted in to secondary accents, so far only pertpy. The generated files are byte-identical except spatialdata, whose rounded OKLCH chroma of 0.2 lies outside sRGB and clips to #00a8ff instead of #40a9ff; 0.158 restores it, so that is fixed on the website rather than here.
Zethson
added a commit
that referenced
this pull request
Oct 22, 2026
The OKLCH conversion in #368 rounded its chroma to 0.2, which lies outside sRGB and clips to #00a8ff on sRGB screens. 0.158 reproduces the previous #40a9ff exactly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To get at that data in a less brittle way.