Repository navigation
as_resolvers: read complete whois banner and guard against None ASN - #5230
Open
BenGardiner wants to merge 1 commit into
Open
BenGardiner wants to merge 1 commit into
BenGardiner wants to merge 1 commit into
Conversation
When reading the WHOIS server banner in AS_resolver._start(), read until stream completion or error response rather than assuming a single 8192-byte read. In AS_resolver6._resolve(), check that asn is not None before calling startswith(). Allow rate-limiting error responses in whois regression tests. AI-Assisted: yes (Gemini)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5230 +/- ##
==========================================
+ Coverage 80.89% 81.20% +0.30%
==========================================
Files 394 394
Lines 98710 98715 +5
==========================================
+ Hits 79853 80158 +305
+ Misses 18857 18557 -300
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading the WHOIS server banner in AS_resolver._start(), read until stream completion or error response rather than assuming a single 8192-byte read. In AS_resolver6._resolve(), check that asn is not None before calling startswith(). Allow rate-limiting error responses in whois regression tests.
AI-Assisted: yes (Gemini)
Description
fixes a failure I saw in CI runs recently