Repository navigation
netbios: fix unhashable list cache key in nbns_resolve (fixes #5202) - #5232
Open
laasyapriya2007 wants to merge 1 commit into
Open
laasyapriya2007 wants to merge 1 commit into
laasyapriya2007 wants to merge 1 commit into
Conversation
laasyapriya2007
force-pushed
the
fix-nbns-resolve-cache-hash
branch
from
October 18, 2026 06:06
667f7ea to
4602079
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of changes
Fixes #5202.
When
nbns_resolve()is called with a list or tuple of query names,_nbns_cache.get(cache_ident)previously raisedTypeError: unhashable type: 'list'because the list was directly placed in the cache tuple key.This PR:
any2iand converts the cache key to a hashabletuple.Noneearly if an empty list of query names is provided.test/scapy/layers/netbios.uts.