Repository navigation
Conversation
Drop end-of-life targets (netstandard1.3, net452, net40) in favour of net8.0, netstandard2.0 and net462. Tests and examples move to net8.0, global.json pins the 8.0 SDK. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves DII-2561.
Changes
SendGrid.csproj:netstandard1.3;netstandard2.0;net452;net40->net8.0;netstandard2.0;net462(drops EOL targets, removes the net40-onlyMicrosoft.Bcl.Async/Microsoft.Net.Httpreferences).ExampleCoreProject->net8.0;ExampleNet45Project->net462.global.jsonpinning the 8.0 SDK;Dockerfilemoved to the .NET 8 SDK image (no mono / SDK 2.1).Breaking: consumers on .NET Framework < 4.6.2, .NET Core < 2.0 or netstandard1.x can no longer install the new version.
Testing
Local .NET 8.0.426 SDK: solution builds with 0 warnings/errors and
dotnet packproduces the package for all three targets. Non-integration tests: 117 pass, 1 fails (LicenseTests.ShouldHaveCurrentYearInLicense, LICENSE says 2024 — unrelated to this change). Integration tests need the Prism mock (make test-docker) and were not run.Merge order
Depends on #1228, which switches the workflows to read the SDK version from
global.json(the old workflows pin 3.1.x and can't build net8.0).🤖 Generated with Claude Code