Repository navigation
Send typing indicators off the main thread - #2242
Draft
mpretty-cyro wants to merge 1 commit into
Draft
mpretty-cyro wants to merge 1 commit into
mpretty-cyro wants to merge 1 commit into
Conversation
Every typing indicator was sent from the input field's text watcher on the main thread: sendTyping read the thread's address and recipient and MessageSender.send persisted a job. When the connection pool was busy, typing froze the conversation until the app was killed for not responding. Sends now run in order on a dedicated background thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
playflavour,debugFixes #1234syntaxDescription
The #1 ANR cluster on 1.33.7 ("Input dispatching timed out", top frame
Unsafe.park) includes samples where the main thread is inConversationActivityV2.setUpTypingObserver→TypingStatusSender.sendTyping→MessageSender.send→JobQueue.add→SessionJobDatabase.persistJob, waiting for a database connection.TypingStatusSendernow does the send (thread address and recipient lookup,MessageSender.send) on a dedicated single backgroundthread. The start/stop timers are unchanged and still run on the main thread; the single thread keeps sends in order.
No change inside
MessageSenderorJobQueue.While the pool is busy, a queued "started" can now go out after a message sent in the meantime, so the recipient may see "typing" until it times out. Sending a message doesn't send "stopped", on
devor here.Testing: reproduced on an emulator with a debug-only hook (not in this PR) that holds the database write lock: with typing indicators on, typing ANR'd on
devwith the main thread inMessageSender.send→JobQueue.add→persistJob. With this change the same steps gave no ANR and no main-thread database access.