Repository navigation
Close a cancelled request's stream off the calling thread - #2248
Draft
mpretty-cyro wants to merge 1 commit into
Draft
mpretty-cyro wants to merge 1 commit into
mpretty-cyro wants to merge 1 commit into
Conversation
Glide cancels image requests on the main thread, for example when the Giphy grid recycles a cell while scrolling or when the activity stops. CallRequestController.cancel() then closed the response body there, and closing a TLS stream can write to the socket, which threw NetworkOnMainThreadException.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
playflavour,debugFixes #1234syntaxDescription
Crash cluster:
NetworkOnMainThreadExceptioninokhttp3.internal._UtilJvmKt.closeQuietly, fromGiphyAdapter.onViewRecycled/onStop→ GlideRequestManager.clear→ChunkedImageUrlFetcher.cancel→CallRequestController.cancel→Util.close. Closing the TLS response body can write to the socket.CallRequestController.cancel()now closes the stream onSignalExecutors.UNBOUNDED.Testing: compiled. Tried to reproduce on
devon an emulator with a throttled network (scrolling the grid and leaving the picker mid-download); it didn't reproduce, so this is untested beyond the normal picker flow.