Repository navigation
Start KeyCachingService when the lock screen is shown, not when created - #2249
Merged
Merged
Conversation
ScreenLockActivity started KeyCachingService in onCreate. The activity can be created while the app is in the background, where Android 12+ throws BackgroundServiceStartNotAllowedException, crashing the launch. Keep binding in onCreate and start the service from onResume, which is always reached before the user can unlock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
playflavour,debugFixes #1234syntaxDescription
Crash cluster:
BackgroundServiceStartNotAllowedExceptionfromScreenLockActivity.onCreate→startService. The activity canbe created while the app is in the background, where Android 12+ refuses
startService.ScreenLockActivitystill binds inonCreateand now starts the service fromonResume. The service has to be started, notjust bound: the static
KeyCachingService.setMasterSecrethelper unbinds straight away, andonDestroyclears the key.Testing: on an emulator with app lock on, cold-launched, unlocked, and checked
KeyCachingServiceis started and in the foreground (dumpsys activity services). Launching with the screen off didn't reproduce the exception ondev, so the crash itself is unconfirmed.