Repository navigation
Report a failed save instead of crashing when MediaStore rejects it - #2251
Draft
mpretty-cyro wants to merge 1 commit into
Draft
mpretty-cyro wants to merge 1 commit into
mpretty-cyro wants to merge 1 commit into
Conversation
ContentResolver.insert throws IllegalArgumentException for values MediaStore won't accept, and can return null; SaveAttachmentTask caught only IOException and dereferenced the result with !!, so saving such an attachment from a conversation or the media preview crashed. Both now end in the existing "save failed" toast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Fixes #1234syntaxDescription
Crash cluster:
IllegalArgumentExceptionfromContentResolver.insertinSaveAttachmentTask.createOutputUri, escapingdoInBackground, which caught onlyIOException. A nullinsertresult was also dereferenced with!!.Both now end in the existing "save failed" toast.
Testing: compiled. A MediaStore rejection wasn't reproduced.