Repository navigation
Don't crash when tapping a document that has no data - #2252
Draft
mpretty-cyro wants to merge 1 commit into
Draft
mpretty-cyro wants to merge 1 commit into
mpretty-cyro wants to merge 1 commit into
Conversation
Outgoing documents are tappable before their attachment reaches DONE, and such a part can have a null URI. PartUriParser then threw a NullPointerException. Show the existing "unable to open" toast instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Fixes #1234syntaxDescription
Crash cluster:
NullPointerExceptioninContentUris.parseIdfromPartUriParser.getId←PartAuthority.getAttachmentPublicUri←VisibleMessageContentViewdocument click. Outgoing documents are tappable beforereaching
DONE, and such a part can have a null URI. Tapping one now shows the existing "unable to open" toast.Testing: compiled. Not reproduced; it needs an outgoing document whose part has no URI.