Repository navigation
Detach a call video renderer before adding it to the call screen - #2253
Merged
Merged
Conversation
The video renderers are owned by CallManager and outlive WebRtcCallActivity, so when a new instance of the screen rendered its video state a renderer could still be attached to the previous instance's layout. addView then threw "The specified child already has a parent".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Fixes #1234syntaxDescription
Crash cluster:
IllegalStateException: The specified child already has a parentfromWebRtcCallActivity.renderVideoState→addView. The renderers belong toCallManagerand outlive the activity, so one can still be attached to a previous instance'slayout. Each renderer is now removed from its current parent before being added.
Testing: compiled. Not exercised on a device; it needs a video call.