Repository navigation
improvement(sim-links): pass queries through, trim pasted punctuation, and suggest links from the address bar - #9508
Merged
Conversation
…, and suggest links from the address bar
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Medium impact] The PR appears safe to merge; both earlier findings are fixed and no new actionable issues were found. SummaryAdds query passthrough, pasted-name cleanup, and address-bar suggestions for Sim Links.
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 17 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…the suggestion cache
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sim/<name>?querynow carries the query to the destination (plain, variable, and default destinations), appended after the destination's own parameters with their stored encoding untouched; the sign-in redirect keeps it toosim/onboarding).) drops the trailing prose punctuation before lookup. Those characters are either ignored when matching or not allowed in names, so no distinct link is shadowed; values are never trimmedsimaddress-bar keyword (sim, Space) suggests matching links as you type, most opened first, and Enter opens what was typed through the resolver. Backed byGET /api/sim-links/suggestions, which reads the same organizationsim/resolves in (one sharedresolveSimLinkOrganization), never suggests unlisted links, and returns nothing where Sim Links is offconnect-srcnow allows only the configured Sim origin, for that one request; README and docs updatedType of Change
Testing
lib/sim-links/destination.test.ts: query passthrough (encoding preserved, duplicate keys, fragments,#in a typed value) and typed-path parsing, red before the changeomniboxkeyword and the narrowed CSP); lint,check:api-validation:strict,check:boundariesChecklist
test-auditauthoring gate)