Skip to content

improvement(desktop): bring agent browser menus, keys and fullscreen in line with Chrome - #9512

Merged
waleedlatif1 merged 2 commits into
stagingfrom
improvement/desktop-browser-hygiene
Oct 31, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
improvement/desktop-browser-hygiene

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Page-menu Back/Forward/Reload called goBack/goForward/reload directly, skipping the leave-site prompt and load-error handling; they now go through the same user-navigation path as the toolbar and shortcuts
  • Page menu: shared spelling suggestions + Add to Dictionary (same builder as the main window), Undo/Redo/Cut/Paste and Match Style/Select All, and image items (Open Image in New Tab, Save Image through the existing download guards, Copy Image, Copy Image Address); Open Link in New Tab sends the referrer
  • Spellcheck on in the agent browser on macOS (native local checker; Windows/Linux stay off since they'd download Hunspell dictionaries)
  • Ctrl+wheel zoom steps the same zoom ladder as the menu (Windows/Linux; Chromium doesn't raise it on macOS)
  • Chrome keys: Alt+Left/Right, Cmd+Opt+Left/Right, Cmd+Shift+[ ], Ctrl+PgUp/PgDn, Esc stops loading, mouse back/forward buttons — all ignore agent-dispatched input and share one per-tab shortcut runner
  • Page fullscreen (YouTube, Loom, Slides) fills the browser panel instead of hanging; the Sim window is never resized
  • Pinch zoom skipped: visual zoom would desync agent screenshot crops and clicks

Type of Change

  • Improvement

Testing

  • New apps/desktop/e2e/browser-page-parity.spec.ts (6 checks, JSON report): menu Back with an unsaved draft asks to leave; Save Image lands byte-for-byte; Open Link in New Tab sends the referrer; tab/history keys; Esc stops a held load; fullscreen resolves without OS fullscreen or panel resize
  • All 6 fail against the original source; reverting only disableHtmlFullscreenWindowResize fails the fullscreen check
  • context-menu.test.ts, session.test.ts, driver.test.ts, main context-menu.test.ts (218 pass), desktop tsc --noEmit, biome on changed files; full gate in CI

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 31, 2026 8:35am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issues were found.

Summary

The PR brings the embedded browser closer to Chrome:

  • The agent browser menu offers more page actions and follows browser navigation.
  • The agent browser responds to more Chrome-style keys and mouse buttons.
  • Page fullscreen and wheel zoom stay within the agent browser panel.

The earlier mouse-button finding is fixed: handleFocusedShortcut now returns before reading browser state when no chat scope is active. The supplied thread is unnumbered, so it has no previousFindings entry.

No new actionable issues were found. This review checked source code; it did not run the desktop tests.

Reviews (2) · Last reviewed commit: "fix(desktop): ignore browser shortcuts a..." · Reviewed by Greptile

Comment thread apps/desktop/src/main/index.ts Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/desktop/src/main/index.ts Resolved
…in line with Chrome

- Page-menu Back/Forward/Reload go through the user-navigation path, so the leave-site prompt and load-error handling apply
- Page menu gains spelling suggestions, Undo/Redo/Cut/Paste and Match Style/Select All, and image items (open, save, copy, copy address); Open Link in New Tab sends the referrer
- Spellcheck on in the agent browser on macOS
- Ctrl+wheel zoom steps the same zoom ladder as the menu
- Chrome keys: Alt+Left/Right, Cmd+Opt+Left/Right, Cmd+Shift+[ ], Ctrl+PgUp/PgDn, Esc stops loading, mouse back/forward buttons
- Page fullscreen fills the browser panel without resizing the Sim window
@waleedlatif1
waleedlatif1 force-pushed the improvement/desktop-browser-hygiene branch from 19b150a to 79f82e8 Compare October 31, 2026 08:35
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 4a7ba87 into staging Oct 31, 2026
47 checks passed

This branch was previously deployed

1 inactive deployment
Preview — 79f82e82 Deployed Oct 31, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant