Repository navigation
improvement(desktop): bring agent browser menus, keys and fullscreen in line with Chrome - #9512
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The PR appears safe to merge; no new actionable issues were found. SummaryThe PR brings the embedded browser closer to Chrome:
The earlier mouse-button finding is fixed: No new actionable issues were found. This review checked source code; it did not run the desktop tests. Reviews (2) · Last reviewed commit: "fix(desktop): ignore browser shortcuts a..." · Reviewed by Greptile |
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…in line with Chrome - Page-menu Back/Forward/Reload go through the user-navigation path, so the leave-site prompt and load-error handling apply - Page menu gains spelling suggestions, Undo/Redo/Cut/Paste and Match Style/Select All, and image items (open, save, copy, copy address); Open Link in New Tab sends the referrer - Spellcheck on in the agent browser on macOS - Ctrl+wheel zoom steps the same zoom ladder as the menu - Chrome keys: Alt+Left/Right, Cmd+Opt+Left/Right, Cmd+Shift+[ ], Ctrl+PgUp/PgDn, Esc stops loading, mouse back/forward buttons - Page fullscreen fills the browser panel without resizing the Sim window
…hat opens a browser
19b150a to
79f82e8
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
Summary
goBack/goForward/reloaddirectly, skipping the leave-site prompt and load-error handling; they now go through the same user-navigation path as the toolbar and shortcutsType of Change
Testing
apps/desktop/e2e/browser-page-parity.spec.ts(6 checks, JSON report): menu Back with an unsaved draft asks to leave; Save Image lands byte-for-byte; Open Link in New Tab sends the referrer; tab/history keys; Esc stops a held load; fullscreen resolves without OS fullscreen or panel resizedisableHtmlFullscreenWindowResizefails the fullscreen checkcontext-menu.test.ts,session.test.ts,driver.test.ts, maincontext-menu.test.ts(218 pass), desktoptsc --noEmit, biome on changed files; full gate in CIChecklist
test-auditauthoring gate)