Repository navigation
improvement(cleanup): tighten the agent-harness changes from the latest audit - #9650
Merged
Merged
Conversation
…st audit - CLI parse-error guidance branches on commander's error codes, reads hidden siblings through Help.visibleCommands, and names a misplaced positional only when unambiguous (no unknown option, one missing required flag, one extra operand); the hint uses the option's long flag, not '-w,' - body-variant shape errors use isRecordLike, compute the shape once, and show a generic example - workflow lint builds sections eagerly, derives hasWorkflowLintIssues from them, and phrases Run-button advice from the issue's fields - shared quotedBlockLabel; formatQuotedNameList takes a quote formatter - grep marks skipped non-text files instead of threading a callback - drop dead run-from-block loop branch and unreachable run-hook guard - shared empty lint report test factory; tighter assertions
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryCleans up CLI error guidance, workflow lint messages, grep skip counts, and shared test fixtures.
waleedlatif1 explicitly describes eager section building as intentional in the PR description. No material performance failure was established. Reviews (1) · Last reviewed commit: "improvement(cleanup): tighten the agent-..." · Reviewed by Greptile |
waleedlatif1
added a commit
that referenced
this pull request
Nov 4, 2026
This was referenced Nov 4, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up cleanup on the recently merged agent-harness changes (#9634–#9646).
CLI parse-error guidance
commander.missingArgument,missingMandatoryOptionValue,excessArguments,unknownOption) instead of matching commander's English message text. Hidden siblings come fromHelp.visibleCommands, and the one remaining private read (_actionHandler) now lives in a single helper,hasOwnAction.xwas passed as a positional; pass it as--flag" only appears when the argv allows no other reading: no unknown option was typed, exactly one required flag is missing, and there is exactly one extra operand. Before, an unknown flag's value, or one of two missing flags, could be named in the hint.-w,.buildLeafwas a pass-through and is now inlined.isRecordLike, compute the shape once, and show a generic example.Workflow lint
hasWorkflowLintIssuesnow derives from the same section list.quotedBlockLabelhelper, used by lint and the Copilot run-from-block refusal.formatQuotedNameListtakes an optional quote formatter.Other
reportNonTextcallback around. Skipped non-text files are marked withnonText: trueinstead, and the output text is unchanged.isLoopNodebranch in run-from-block (findOutermostContaineralready catches it) and the unreachable!startBlockIdguard in the run hook.createEmptyWorkflowLintReportfactory in@sim/testing, tighter Copilot assertions, a Drizzle insert in place of raw SQL indelivery.integration.ts, and updated test comments.Test plan
build.test.ts. All three fail on the code before this change and pass after it.bun run lint; type-check for sim-cli, testing, and utils;check:utils,check:comment-hygiene,check:test-patterns,check:file-names.